feat: support to enable quic and add basic test case#10989
Merged
Conversation
zll600
commented
Mar 4, 2024
| set -ex | ||
|
|
||
| # use curl which supports http3 to test. | ||
| install_static_curl |
Contributor
Author
There was a problem hiding this comment.
curl from apt does not support option --http3-only to test. So we need a newer version of curl
zll600
commented
Mar 4, 2024
zll600
marked this pull request as ready for review
March 4, 2024 07:37
membphis
reviewed
Mar 4, 2024
zll600
commented
Mar 4, 2024
| if ip_port_to_check[addr] == nil then | ||
| table_insert(listen_table, | ||
| {ip = ip, port = port, enable_http2 = enable_http2}) | ||
| { |
Contributor
There was a problem hiding this comment.
can you explain the usage of this block briefly? And why this change is needed.
Contributor
Author
There was a problem hiding this comment.
because I want to add a new field enable_quic. If I add enable_quic directly, the length of this line will be too long to cause a lint error.
membphis
reviewed
Mar 5, 2024
membphis
reviewed
Mar 5, 2024
membphis
reviewed
Mar 6, 2024
membphis
left a comment
membphis
left a comment
Member
There was a problem hiding this comment.
LGTM
need a better title, eg: feat: support to enable quic and add basic test case
zll600
changed the title
juststillthinking
approved these changes
Mar 6, 2024
This was referenced Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6403
support enable quic for apisix.
I will add a how-to guide in another PR.
Checklist