feat: consul deduplicate and ip port sort#10941
Merged
juststillthinking merged 17 commits intoFeb 27, 2024
Merged
Conversation
Contributor
|
please make the ci pass |
Contributor
|
Can we add test cases to cover this? |
Contributor
Author
yeah, I add it, But I forgot it😂. |
Contributor
Author
|
@monkeyDluffy6017 It's already been added. |
juststillthinking
previously approved these changes
Feb 22, 2024
shreemaan-abhishek
previously approved these changes
Feb 23, 2024
Neilblaze
approved these changes
Feb 25, 2024
| qr// | ||
| ] | ||
| --- ignore_error_log | ||
|
|
Contributor
There was a problem hiding this comment.
This file is too long, you should create a new test file
theweakgod
dismissed stale reviews from shreemaan-abhishek and juststillthinking
via
February 26, 2024 07:14
8a14c7a
shreemaan-abhishek
approved these changes
Feb 26, 2024
juststillthinking
approved these changes
Feb 27, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10882
Remove duplicate services caused by each node in the Consul cluster, and add sorting by host_sort, port_sort, combine_sort.
Checklist