Skip to content

fix(datadog): use the username property instead of the whole table when generating the tag#10934

Closed
ecoupal-believe wants to merge 1 commit into
apache:masterfrom
ecoupal-believe:fix/datadog-consumer
Closed

fix(datadog): use the username property instead of the whole table when generating the tag#10934
ecoupal-believe wants to merge 1 commit into
apache:masterfrom
ecoupal-believe:fix/datadog-consumer

Conversation

@ecoupal-believe

Copy link
Copy Markdown

Description

Use the username property instead of the whole table when generating the tag.

Fixes #9269

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@shreemaan-abhishek

Copy link
Copy Markdown
Contributor

@ecoupal-believe please add test cases as well.

@juststillthinking juststillthinking changed the title Fix datadog plugin with consumer fix(datadog): use the username property instead of the whole table when generating the tag Feb 18, 2024
@github-actions

Copy link
Copy Markdown

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions.

@github-actions github-actions Bot added the stale label Apr 18, 2024
@github-actions

Copy link
Copy Markdown

This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.

@bzp2010

bzp2010 commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

Fixed by #11354, thanks @ecoupal-believe 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: datadog plugin failed to send metric when consumer is used with route for authentication

3 participants