feat(discovery): support endpointslices in kubernetes discovery#10916
Merged
juststillthinking merged 8 commits intoFeb 23, 2024
Conversation
Signed-off-by: dongjiang1989 <[email protected]>
dongjiang1989
commented
Feb 5, 2024
Signed-off-by: dongjiang1989 <[email protected]>
Contributor
|
@dongjiang1989 please explain why this is needed, thanks. |
Contributor
Author
@shreemaan-abhishek thanks for your review. EndpointSlices provide a simple way to track network endpoints within a Kubernetes cluster. They offer a more scalable and extensible alternative to Endpoints. |
Contributor
|
Could you add test cases to cover this? |
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Contributor
Author
|
@monkeyDluffy6017 @shreemaan-abhishek Please re-check. Thanks |
5 tasks
Contributor
|
@zhixiongdu027 Could you help to review this pr? |
Contributor
|
We should update the documentation for this feature. |
Signed-off-by: dongjiang1989 <[email protected]>
Contributor
Author
Thanks. Added it |
Signed-off-by: dongjiang1989 <[email protected]>
Contributor
Author
|
/test |
Contributor
Author
|
@AlinsRan @shreemaan-abhishek @monkeyDluffy6017 please re-check,thanks |
AlinsRan
approved these changes
Feb 22, 2024
juststillthinking
approved these changes
Feb 23, 2024
Contributor
|
@dongjiang1989 |
Closed
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR add support endpointslices in kubernetes discovery
Checklist