Skip to content

feat(discovery): support endpointslices in kubernetes discovery#10916

Merged
juststillthinking merged 8 commits into
apache:masterfrom
dongjiang1989:support-endpointslices
Feb 23, 2024
Merged

feat(discovery): support endpointslices in kubernetes discovery#10916
juststillthinking merged 8 commits into
apache:masterfrom
dongjiang1989:support-endpointslices

Conversation

@dongjiang1989

Copy link
Copy Markdown
Contributor

Description

This PR add support endpointslices in kubernetes discovery

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Signed-off-by: dongjiang1989 <[email protected]>
Comment thread apisix/discovery/kubernetes/init.lua Outdated
@shreemaan-abhishek

Copy link
Copy Markdown
Contributor

@dongjiang1989 please explain why this is needed, thanks.

@dongjiang1989

Copy link
Copy Markdown
Contributor Author

@dongjiang1989 please explain why this is needed, thanks.

@shreemaan-abhishek thanks for your review.

EndpointSlices provide a simple way to track network endpoints within a Kubernetes cluster. They offer a more scalable and extensible alternative to Endpoints.

ref: https://kubernetes.io/docs/concepts/services-networking/endpoint-slices/

@juststillthinking

Copy link
Copy Markdown
Contributor

Could you add test cases to cover this?

Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
Signed-off-by: dongjiang1989 <[email protected]>
@dongjiang1989

Copy link
Copy Markdown
Contributor Author

@monkeyDluffy6017 @shreemaan-abhishek Please re-check. Thanks

Comment thread t/kubernetes/discovery/kubernetes.t
Comment thread apisix/discovery/kubernetes/informer_factory.lua
@juststillthinking

Copy link
Copy Markdown
Contributor

@zhixiongdu027 Could you help to review this pr?

@AlinsRan

Copy link
Copy Markdown
Contributor

We should update the documentation for this feature.

Signed-off-by: dongjiang1989 <[email protected]>
@dongjiang1989

dongjiang1989 commented Feb 19, 2024

Copy link
Copy Markdown
Contributor Author

We should update the documentation for this feature.

Thanks. Added it

Signed-off-by: dongjiang1989 <[email protected]>
@dongjiang1989

Copy link
Copy Markdown
Contributor Author

/test

@dongjiang1989

Copy link
Copy Markdown
Contributor Author

@AlinsRan @shreemaan-abhishek @monkeyDluffy6017 please re-check,thanks

@juststillthinking
juststillthinking merged commit 869d095 into apache:master Feb 23, 2024
@dongjiang1989
dongjiang1989 deleted the support-endpointslices branch February 23, 2024 11:20
@liugang594

Copy link
Copy Markdown
Contributor

@dongjiang1989
咨询一下,咱们这个endpointslice的支持,最终得到服务节点列表是全量的么?看代码中像是只得到了最后变更的slice的pod ip列表。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants