Skip to content

fix: when delete the secret cause 500 error #10902

Merged
shreemaan-abhishek merged 4 commits into
apache:masterfrom
hanqingwu:fix-10823
Feb 21, 2024
Merged

fix: when delete the secret cause 500 error #10902
shreemaan-abhishek merged 4 commits into
apache:masterfrom
hanqingwu:fix-10823

Conversation

@hanqingwu

@hanqingwu hanqingwu commented Feb 2, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #10823

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@hanqingwu hanqingwu changed the title Fix: when delete the secret cause 500 error fix: when delete the secret cause 500 error Feb 2, 2024
@juststillthinking

Copy link
Copy Markdown
Contributor

Test cases are needed

@shreemaan-abhishek shreemaan-abhishek added wait for update wait for the author's response in this issue/PR need test cases labels Feb 5, 2024
@shreemaan-abhishek

Copy link
Copy Markdown
Contributor

pls fix the CI

@juststillthinking

Copy link
Copy Markdown
Contributor

@soulbird please help to check

Comment thread t/secret/secret_lru.t
soulbird
soulbird previously approved these changes Feb 7, 2024
@juststillthinking juststillthinking added approved and removed wait for update wait for the author's response in this issue/PR need test cases labels Feb 20, 2024
@shreemaan-abhishek
shreemaan-abhishek merged commit 1d57986 into apache:master Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: use secret can cause 500 stack error in some case.

4 participants