Skip to content

feat: add option to include request body and response body in log util#10888

Merged
juststillthinking merged 13 commits into
apache:masterfrom
smileby:feat_include-body
Feb 2, 2024
Merged

feat: add option to include request body and response body in log util#10888
juststillthinking merged 13 commits into
apache:masterfrom
smileby:feat_include-body

Conversation

@smileby

@smileby smileby commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes #10803

The request body and response body related attributes are added to the log plug-in. The list is as follows：

  • elasticsearch-logger
  • skywalking-logger
  • syslog
  • sls-logger
  • tcp-logger
  • udp-logger

upplement the description of existing attributes missing in the Chinese document. The list is as follows：

  • loggly
  • tencent-cloud-cls

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@smileby

smileby commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

@shreemaan-abhishek Please help to check, thanks

@smileby

smileby commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

@shreemaan-abhishek I don’t think the ci error is caused by this PR, please help check. Thanks

shreemaan-abhishek
shreemaan-abhishek requested changes Jan 31, 2024
View reviewed changes

@shreemaan-abhishek shreemaan-abhishek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please provide test cases for other plugnis as well.

@smileby

smileby commented Jan 31, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

please provide test cases for other plugnis as well.

@shreemaan-abhishek Can the test cases be completed by adding logs in the plug-in? I can't seem to use assertions without increasing the log

@shreemaan-abhishek

shreemaan-abhishek commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

@smileby I didn't get you.

@juststillthinking

juststillthinking commented Feb 1, 2024

Copy link
Copy Markdown
Contributor

@smileby please resolve the conflicts

@smileby

smileby commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@smileby please resolve the conflicts

Thanks for the reminder, I have solved it

@smileby

smileby commented Feb 1, 2024

Copy link
Copy Markdown
Contributor Author

@smileby I didn't get you.

@shreemaan-abhishek I added the info log in the plug-in to facilitate me to write test cases. The code has been submitted, please help to check, thank you

shreemaan-abhishek
shreemaan-abhishek approved these changes Feb 1, 2024
View reviewed changes

@shreemaan-abhishek shreemaan-abhishek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@juststillthinking
juststillthinking merged commit 07c4aa3 into apache:master Feb 2, 2024
@smileby
smileby deleted the feat_include-body branch February 2, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes
+1 more reviewer
@juststillthinking juststillthinking juststillthinking approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Add schema attribute definition for some log plug-ins

3 participants

@smileby @shreemaan-abhishek @juststillthinking