fix: grpc-web trailers#10851
Conversation
|
This PR is not yet complete, need to add some features. |
|
@sheharyaar hello~ have u test on your enviorment? u can add some testcase that can help us to review~~ |
|
@Vacant2333 , I have added test-cases, please approve workflow |
|
@sheharyaar Is this pr ready? |
|
Yes, the PR is ready @monkeyDluffy6017 |
Missing trailers issue fixed but path based testing cannot be done until the cors issue is resolved. Access to XMLHttpRequest at 'https://XXXXXXXX/RANDOM.RANDOM.SERVICENAME.service.ServiceExternal/SERVICEMETHOF' from origin 'http://localhost:8080/' has been blocked by CORS policy: Request header field REDACTED_FIELD is not allowed by Access-Control-Allow-Headers in preflight response. The issue persistents even when using cors plugin alongside this plugin. Please replicate on your end |
Vacant2333
left a comment
Vacant2333
left a comment
There was a problem hiding this comment.
hi, the ci was failed mostly, u can merge the master after the pr get merged~ it will fix it
|
r u ready to review and merge now? @shreemaan-abhishek can u help take a look~ |
|
Yes, I am ready |
|
please fix ci |
|
I am having issues with this. Locally it works fine for me. I need help with this. |
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
Signed-off-by: Mohammad Shehar Yaar Tausif <[email protected]>
## Description backports: apache#10904 and apache#10851 ## Checklist - [ ] I have explained **WHY** we need this PR and **HOW** the problem it solves - [ ] The title of the PR concisely describes the code modification and complies with APISIX specifications. - [ ] I have explained the changes or the new features added to this PR - [ ] I have added **e2e test cases** corresponding to this change - [ ] I have updated the documentation to reflect this change **NOTE: This PR will not be reviewed and merged until the contents of these checklists are completed.**
6 participants
Description
Fixes #10573 and closes #10613
Checklist