fix(elasticsearch-logger): add compatibility headers#10828
Merged
Conversation
Member
|
Could you check the failing test cases? It is because of this change. |
lakshya8066
changed the title
shreemaan-abhishek
marked this pull request as ready for review
January 18, 2024 03:34
juststillthinking
changed the title
Contributor
I didn't see this? |
Contributor
Author
|
oh my bad, initially this PR was supposed to change the version as well but I am getting errors on upgrading the version. I don't know how to solve the errors. |
juststillthinking
marked this pull request as draft
January 19, 2024 01:59
juststillthinking
marked this pull request as ready for review
January 19, 2024 01:59
Contributor
|
The pr seems not ready if you don't upgrade the elasticsearch |
shreemaan-abhishek
requested review from
AlinsRan,
juststillthinking and
pottekkat
January 26, 2024 08:28
Contributor
|
@gaoxingliang please review if you can. |
juststillthinking
approved these changes
Feb 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
7.xto8.xFixes #8647
Checklist