Skip to content

feat: add ocsp-stapling plugin#10817

Merged
juststillthinking merged 31 commits into
apache:masterfrom
yuweizzz:ocsp
Jan 24, 2024
Merged

feat: add ocsp-stapling plugin#10817
juststillthinking merged 31 commits into
apache:masterfrom
yuweizzz:ocsp

Conversation

@yuweizzz

@yuweizzz yuweizzz commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

Description

Related: #10309

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@juststillthinking

Copy link
Copy Markdown
Contributor

Thanks for your contribution! we will check this later

Comment thread apisix/plugins/ocsp-stapling.lua
Comment thread apisix/plugins/ocsp-stapling.lua
Comment thread apisix/plugins/ocsp-stapling.lua Outdated
Comment thread apisix/plugins/ocsp-stapling.lua Outdated
Comment thread apisix/plugins/ocsp-stapling.lua
Comment thread apisix/plugins/ocsp-stapling.lua Outdated
@juststillthinking

Copy link
Copy Markdown
Contributor

Nice work!

Comment thread t/plugin/ocsp-stapling.t Outdated
@juststillthinking juststillthinking added the wait for update wait for the author's response in this issue/PR label Jan 18, 2024
@juststillthinking

Copy link
Copy Markdown
Contributor

@yuweizzz please make the ci pass

@juststillthinking

Copy link
Copy Markdown
Contributor

please merge the master branch

@yuweizzz

Copy link
Copy Markdown
Contributor Author

merged.

@juststillthinking
juststillthinking merged commit fa3f220 into apache:master Jan 24, 2024
@ssdr

ssdr commented Oct 29, 2024

Copy link
Copy Markdown

It seems that set_ocsp_resp is not correct when supporting multiple certificates.

end
local fin_pem_cert = value.cert
-- multiple certificates support.
if value.certs then
for i = 1, #value.certs do
local cert = value.certs[i]
local key = value.keys[i]
ok, err = radixtree_sni.set_pem_ssl_key(sni, cert, key)
if not ok then
return false, err
end
fin_pem_cert = cert
end
end
local ok, err = set_ocsp_resp(fin_pem_cert,
value.ocsp_stapling.skip_verify,
value.ocsp_stapling.cache_ttl)

@yuweizzz

Copy link
Copy Markdown
Contributor Author

It seems that set_ocsp_resp is not correct when supporting multiple certificates.

end
local fin_pem_cert = value.cert
-- multiple certificates support.
if value.certs then
for i = 1, #value.certs do
local cert = value.certs[i]
local key = value.keys[i]
ok, err = radixtree_sni.set_pem_ssl_key(sni, cert, key)
if not ok then
return false, err
end
fin_pem_cert = cert
end
end
local ok, err = set_ocsp_resp(fin_pem_cert,
value.ocsp_stapling.skip_verify,
value.ocsp_stapling.cache_ttl)

Could you provide the log info or reproduction steps and create a new issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

user responded wait for update wait for the author's response in this issue/PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants