fix(openid-connect): openid not closing session and blocking until ttl…#10788
Merged
juststillthinking merged 2 commits intoJan 17, 2024
Merged
Conversation
markusmueller
changed the title
markusmueller
marked this pull request as draft
January 9, 2024 09:00
markusmueller
marked this pull request as ready for review
January 9, 2024 09:01
Contributor
|
We need a test case to cover this |
Contributor
|
@markusmueller , can you please add a test case for the PR?? |
markusmueller
force-pushed
the
fix-openid-session-close
branch
from
January 11, 2024 13:30
c228f26 to
8996221
Compare
Contributor
Author
|
@sheharyaar I have added a test verifying the session lock is not blocking subsequent requests anymore as the session is closed properly (test will fail without the change in the plugin). |
…l expired when using lockable session storage backend (apache#8017)
markusmueller
force-pushed
the
fix-openid-session-close
branch
from
January 11, 2024 21:41
8996221 to
19a20bf
Compare
juststillthinking
previously approved these changes
Jan 12, 2024
juststillthinking
added
wait for update
Co-authored-by: Liu Wei <[email protected]>
Contributor
Author
|
@monkeyDluffy6017 applied your suggestions, thank you |
juststillthinking
approved these changes
Jan 15, 2024
juststillthinking
added
approved
and removed
wait for update
AlinsRan
approved these changes
Jan 16, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l expired when using lockable session storage backend (#8017)
Description
Fixes #8017
I'm not a Lua developer but I'd really like to see this fixed. It might be appropriate to wrap with a pcall and have the session closed in any case (try-catch-finally). Also, I couldn't quickly figure out if the testing would cover configuring and spinning up a locking session storage (memcache for example) to test this. If so, happy to add a test case.
Thank you for your feedback.
Checklist