Skip to content

feat: Add schema attribute definition for some log plug-ins#10738

Merged
juststillthinking merged 1 commit into
apache:masterfrom
smileby:feat-add_attr_for_schema_definition
Jan 3, 2024
Merged

feat: Add schema attribute definition for some log plug-ins#10738
juststillthinking merged 1 commit into
apache:masterfrom
smileby:feat-add_attr_for_schema_definition

Conversation

@smileby

@smileby smileby commented Dec 31, 2023

Copy link
Copy Markdown
Contributor

Description

fixed #9190

Add schema attribute definition for some log plug-ins.

schema attribute details as follows
Add include_req_body and include_req_body_expr attributes to file-logger
Add include_req_body_expr attributes to http-logger
Add include_req_body_expr attributes to loggly
Add include_resp_body_expr and include_resp_body_expr attributes to tencent-cloud-cls

Fixes # (issue)

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@smileby

smileby commented Jan 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Please advise on how to resolve the following issue.

[ info ] stop -> [ Start ]
/home/runner/work/apisix/apisix/bin/apisix stop
/usr/local/openresty//luajit/bin/luajit ./apisix/cli/apisix.lua stop
Error: nginx: [error] open() "/home/runner/work/apisix/apisix/logs/nginx.pid" failed (2: No such file or directory)
[ info ] stop -> [ Done ]
+ git checkout conf/config.yaml
Updated 0 paths from the index
Error: Process completed with exit code 1.

@juststillthinking

juststillthinking commented Jan 2, 2024

Copy link
Copy Markdown
Contributor

It doesn't matter, the ci CLI Test fails occasionaly, we will fix it later

@juststillthinking
juststillthinking merged commit 2f6fd50 into apache:master Jan 3, 2024
@smileby
smileby deleted the feat-add_attr_for_schema_definition branch January 3, 2024 02:43
@smileby smileby mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes
+1 more reviewer
@juststillthinking juststillthinking juststillthinking approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: attributes undocumented for certain logging plugins

3 participants

@smileby @juststillthinking @shreemaan-abhishek