feat: add http-dubbo plugin by ShenFeng312 · Pull Request #10703 · apache/apisix

ShenFeng312 · 2023-12-25T02:30:57Z

Description

添加http-dubbo 插件提供http 协议转dubbo 协议。并使用json作为默认的序列化方式。备注:2.xdubbo可能需要对dubbo 源码进行一定量改造。因为2.xdubbo 如果不全局使用fastjson作为序列化方式时，在对返回结果进行序列化时没有按照协议规定选择序列化方式。这是dubbo2.x的bug。

Add the http-dubbo plugin to facilitate the conversion from HTTP protocol to Dubbo protocol, utilizing JSON as the default serialization format. Note: For Dubbo 2.x, it may be necessary to make certain modifications to the Dubbo source code. This is because, in Dubbo 2.x, if fastjson is not used globally as the serialization method, there is a bug where the serialization format for returning results is not selected according to the protocol specifications during the serialization process.
-------Translated by ChatGPT.

Checklist

I have explained the need for this PR and the problem it solves
I have explained the changes or the new features added to this PR
I have added tests corresponding to this change
I have updated the documentation to reflect this change
I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

smileby · 2023-12-25T03:25:47Z

Could you add test cases？

ShenFeng312 · 2023-12-25T05:24:27Z

Could you add test cases？

Yes, I am learning how to write test cases. I will add them later.

Vacant2333 · 2023-12-25T08:17:26Z

we may need docs for the plugin

ShenFeng312 · 2023-12-27T05:25:42Z

@smileby @soulbird Sorry, I'm busy now. I will fix them and add test cases next week.

ShenFeng312 · 2024-01-11T02:40:00Z

I will add more test cases after these two have been completed

@smileby @soulbird

juststillthinking · 2024-01-11T06:43:23Z

please merge the master

ShenFeng312 · 2024-01-24T13:34:52Z

please make the ci pass

Hi. Ci passed. I think we can merge this PR now @monkeyDluffy6017

Vacant2333 · 2024-01-24T14:41:50Z

please make the ci pass

Hi. Ci passed. I think we can merge this PR now @monkeyDluffy6017

this pr needs review first, its a big one, may takes some days, @shreemaan-abhishek @zll600 @sheharyaar can u help take a look~

juststillthinking · 2024-01-25T08:22:15Z

@ShenFeng312 there is still a ci error

shreemaan-abhishek · 2024-01-25T09:29:04Z

please add docs as well.

ShenFeng312 · 2024-01-25T13:19:54Z

please add docs as well.

OK I will

Vacant2333 · 2024-01-25T15:41:29Z

please add docs as well.

can we add the docs after the pr merge? its a big one i think we can split it

sheharyaar · 2024-01-25T16:05:29Z

@ShenFeng312 , is this PR related to dubbo-proxy ?? And is it related to this issue :
#10848 ??

ShenFeng312 · 2024-01-26T01:15:45Z

@ShenFeng312 , is this PR related to dubbo-proxy ?? And is it related to this issue : #10848 ??

The PR is not related to dubbo-proxy. However, it addresses the requirements mentioned in issue #10848 and should help resolve that issue.

juststillthinking · 2024-01-31T04:15:47Z

Please make the ci pass

ShenFeng312 · 2024-02-01T04:01:54Z

@monkeyDluffy6017 it was OK

ShenFeng312 added 2 commits December 25, 2023 10:22

add http-dubbo plugin

ae3a219

Merge branch 'master' of github.com:ShenFeng312/apisix

f3e4a03

ShenFeng312 changed the title ~~add http-dubbo plugin~~ feat:add http-dubbo plugin Dec 25, 2023

ShenFeng312 changed the title ~~feat:add http-dubbo plugin~~ feat: add http-dubbo plugin Dec 25, 2023

ShenFeng312 added 2 commits December 25, 2023 11:00

fix params append

1445d09

add License

d129cf3

juststillthinking added the need test cases label Dec 25, 2023

soulbird reviewed Dec 26, 2023

View reviewed changes

Comment thread apisix/plugins/http-dubbo.lua Outdated

Comment thread apisix/plugins/http-dubbo.lua Outdated

Comment thread apisix/plugins/http-dubbo.lua

Comment thread apisix/plugins/http-dubbo.lua

smileby reviewed Dec 26, 2023

View reviewed changes

Comment thread apisix/plugins/http-dubbo.lua Outdated

Comment thread apisix/plugins/http-dubbo.lua Outdated

github-actions Bot added the user responded label Dec 27, 2023

juststillthinking removed the user responded label Dec 28, 2023

ShenFeng312 added 2 commits January 10, 2024 14:56

add http-dubbo test cases and fix cr

202a523

add License

e694b7a

ShenFeng312 requested review from smileby and soulbird January 10, 2024 07:56

polish

3d41ca5

github-actions Bot added the user responded label Jan 11, 2024

moonming requested review from juststillthinking, shreemaan-abhishek and smileby and removed request for smileby January 11, 2024 03:32

ShenFeng312 added 2 commits January 11, 2024 11:42

fix ci

31ae727

fix ci

e8ff79e

Vacant2333 suggested changes Jan 12, 2024

View reviewed changes

Comment thread ...-backend-interface/src/main/java/org/apache/dubbo/backend/DubboSerializationTestService.java Outdated

Comment thread ...-backend-interface/src/main/java/org/apache/dubbo/backend/DubboSerializationTestService.java

ShenFeng312 and others added 9 commits January 24, 2024 16:08

fix ci

33a47ee

fix ci

56a159f

Merge branch 'master' of github.com:ShenFeng312/apisix

d08cdb1

fix test

ef24da9

fix test

9ba3458

fix ci

3707b29

fix ci

b948642

fix http-dubbo params len

a8027ef

fix http-dubbo params

43f4269

fix codestyle

7084aa3

juststillthinking removed the user responded label Jan 31, 2024

ShenFeng312 and others added 2 commits February 1, 2024 10:20

fix codestyle

45f319a

Merge branch 'apache:master' into master

64d65f7

github-actions Bot added the user responded label Feb 1, 2024

juststillthinking approved these changes Feb 1, 2024

View reviewed changes

AlinsRan approved these changes Feb 1, 2024

View reviewed changes

juststillthinking merged commit ca81d16 into apache:master Feb 1, 2024

sheharyaar mentioned this pull request Feb 1, 2024

feat: common dubbo-proxy plugin #10848

Closed

ShenFeng312 mentioned this pull request Feb 22, 2024

bug: dubbo-proxy timeout #10620

Closed

kayx23 mentioned this pull request Mar 20, 2024

docs: add docs for http-dubbo plugin #11067

Closed

Uh oh!

Conversation

ShenFeng312 commented Dec 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Checklist

Uh oh!

smileby commented Dec 25, 2023

Uh oh!

ShenFeng312 commented Dec 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Vacant2333 commented Dec 25, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ShenFeng312 commented Dec 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShenFeng312 commented Jan 11, 2024

Uh oh!

juststillthinking commented Jan 11, 2024

Uh oh!

Uh oh!

Uh oh!

ShenFeng312 commented Jan 24, 2024

Uh oh!

Vacant2333 commented Jan 24, 2024

Uh oh!

juststillthinking commented Jan 25, 2024

Uh oh!

shreemaan-abhishek commented Jan 25, 2024

Uh oh!

ShenFeng312 commented Jan 25, 2024

Uh oh!

Vacant2333 commented Jan 25, 2024

Uh oh!

sheharyaar commented Jan 25, 2024

Uh oh!

ShenFeng312 commented Jan 26, 2024

Uh oh!

juststillthinking commented Jan 31, 2024

Uh oh!

ShenFeng312 commented Feb 1, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

ShenFeng312 commented Dec 25, 2023 •

edited

Loading

ShenFeng312 commented Dec 25, 2023 •

edited

Loading

ShenFeng312 commented Dec 27, 2023 •

edited

Loading