fix: not saving etcd revision#10671
Merged
juststillthinking merged 3 commits intoDec 21, 2023
Merged
Conversation
juststillthinking
requested review from
Revolyssup,
bzp2010,
jiangfucheng and
shreemaan-abhishek
December 20, 2023 10:03
AlinsRan
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to the fix, the saved etcd revision will be discarded when re-watch etcd, APISIX need to re-traverse all keys in etcd every time, that leads to high cpu usage
Fixes # (issue)
Checklist