fix: memory leak caused by timer that never quit#10614
Merged
juststillthinking merged 3 commits intoDec 11, 2023
Merged
Conversation
kingluo
removed their request for review
December 8, 2023 01:58
juststillthinking
requested review from
AlinsRan,
bzp2010 and
shreemaan-abhishek
December 8, 2023 03:57
This was referenced Dec 8, 2023
bzp2010
approved these changes
Dec 11, 2023
AlinsRan
approved these changes
Dec 11, 2023
5 tasks
|
May I ask when the updated version will be fixed? I don't want to roll back the version. |
Contributor
Author
|
@Virgil-Zhou No plan right now, maybe you could pick it yourself? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The etcd related pr imported a timer that never quits.
According to the official recommendation, the timer will cause memory leak.
It will affect all versions between 3.4.0 and 3.7.0, including 3.2.2
Fixes #10392 #10349
steps to reproduce
Frequent configuration changes can cause memory to keep going up.
The memory goes from 0.2% to 1.7% in few hours
And the memory keeps stable after fixed
Checklist