feat: create new event module for decouple logic and specific library#10558
Merged
juststillthinking merged 7 commits intoNov 30, 2023
Conversation
Contributor
Author
|
Should the |
Contributor
|
Contributor
|
@bzp2010 i prefer to |
juststillthinking
added
the
wait for update
juststillthinking
approved these changes
Nov 30, 2023
juststillthinking
added
approved
and removed
wait for update
AlinsRan
approved these changes
Nov 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Since we wanted to introduce a new implementation (#10550) of the event library, and the current code strongly relies on
lua-resty-worker-events.Therefore we need a new abstraction layer to accommodate the library API differences and to unify the usage logic within the APISIX gateway. So that the code no longer connects directly to a specific library.
This PR is supposed to not break any existing tests, as there are no substantive changes at this time.
Checklist