feat: add brotli plugin#10515
Merged
Merged
Conversation
Member
|
@yuweizzz great work 👍 |
Contributor
Author
|
sure, I will add a documentation about it. |
Contributor
|
Nice work! Could you make the ci pass? |
juststillthinking
added
the
wait for update
Contributor
Author
|
I don't know why it couldn't work in redhat series, need some time to figure it out. |
juststillthinking
added
the
wait for update
juststillthinking
previously approved these changes
Dec 5, 2023
rickyxucn
approved these changes
Dec 5, 2023
Contributor
|
please make the ci pass |
juststillthinking
approved these changes
Dec 7, 2023
juststillthinking
added
approved
and removed
wait for update
|
|
||
| local types = conf.types | ||
| local content_type = ngx_header["Content-Type"] | ||
| if not content_type then |
Contributor
There was a problem hiding this comment.
how about checking content-type before check_accept_encoding?
Contributor
Author
There was a problem hiding this comment.
I think we should check accept encoding first, if request not allow this encoding, we don't need to check our conf.
shreemaan-abhishek
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add brotli plugin. fixes #9645
Checklist