Skip to content

feat: body-transformer plugin enhancement(#10472)#10496

Merged
juststillthinking merged 4 commits into
apache:masterfrom
yongxiaodong:master
Nov 27, 2023
Merged

feat: body-transformer plugin enhancement(#10472)#10496
juststillthinking merged 4 commits into
apache:masterfrom
yongxiaodong:master

Conversation

@yongxiaodong

@yongxiaodong yongxiaodong commented Nov 15, 2023

Copy link
Copy Markdown
Contributor

Description

  • Support content-type using x-www-form-urlencoded format
  • Supports parsing uri parameters of get requests

Fixes #10472

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

Comment thread t/plugin/body-transformer.t
@shreemaan-abhishek

Copy link
Copy Markdown
Contributor

Do you plan to support gzip as mentioned in the linked issue?

@yongxiaodong

Copy link
Copy Markdown
Contributor Author

Do you plan to support gzip as mentioned in the linked issue?

The apisix gateway usually transmits data through the intranet and upstream. I think there are very few usage scenarios of gzip on the intranet, and gzip will greatly reduce the performance of apisix. What do you think?

Comment thread apisix/plugins/body-transformer.lua Outdated
Comment thread apisix/plugins/body-transformer.lua Outdated
Comment thread apisix/plugins/body-transformer.lua
Comment thread t/plugin/body-transformer.t Outdated



=== TEST 15: The template uses x-www-form-urlencoded format

@juststillthinking juststillthinking Nov 21, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong title? test template_is_base64 here? what's the purpose of this test case?

Comment thread t/plugin/body-transformer.t Outdated
@juststillthinking juststillthinking added the wait for update wait for the author's response in this issue/PR label Nov 21, 2023
@juststillthinking

Copy link
Copy Markdown
Contributor

The ci is unstable, i will approve this after fix the ci

@juststillthinking

Copy link
Copy Markdown
Contributor

@yongxiaodong please merge the master to fix the ci

@yongxiaodong

Copy link
Copy Markdown
Contributor Author

CI still has errors

@yongxiaodong

Copy link
Copy Markdown
Contributor Author

done

@juststillthinking juststillthinking added approved and removed wait for update wait for the author's response in this issue/PR user responded labels Nov 27, 2023
@juststillthinking
juststillthinking merged commit f28de3a into apache:master Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: body-transformer enhancement

3 participants