Skip to content

test: use http2 to test limit-conn plugin#10332

Merged
juststillthinking merged 7 commits into
apache:masterfrom
starsz:chore_add_http2_testcase
Oct 18, 2023
Merged

test: use http2 to test limit-conn plugin#10332
juststillthinking merged 7 commits into
apache:masterfrom
starsz:chore_add_http2_testcase

Conversation

@starsz

@starsz starsz commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

Description

In this PR, I use curl send http2 request to test the limit connection.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@starsz
starsz marked this pull request as draft October 13, 2023 09:10
@starsz starsz changed the title test: use http2 to test limit-connection plugin test: use http2 to test limit-conn plugin Oct 13, 2023
@starsz
starsz force-pushed the chore_add_http2_testcase branch 2 times, most recently from ef2c7dd to 5e5303f Compare October 17, 2023 03:08
@starsz
starsz force-pushed the chore_add_http2_testcase branch from 5e5303f to b2afa08 Compare October 17, 2023 03:43
@starsz
starsz marked this pull request as ready for review October 17, 2023 06:46
Comment thread t/plugin/limit-conn3.t Outdated

add_block_preprocessor(sub {
my ($block) = @_;
my $port = $ENV{TEST_NGINX_SERVER_PORT};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this do?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment thread t/plugin/limit-conn3.t Outdated
my ($block) = @_;
my $port = $ENV{TEST_NGINX_SERVER_PORT};

my $TEST_NGINX_HTML_DIR ||= html_dir();

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@juststillthinking
juststillthinking merged commit d0085f2 into apache:master Oct 18, 2023
@starsz
starsz deleted the chore_add_http2_testcase branch October 18, 2023 03:23
hongbinhsu pushed a commit to fitphp/apix that referenced this pull request Nov 1, 2023
* upstream/master: (83 commits)
  fix: make install failed on mac (apache#10403)
  feat(zipkin): add variable (apache#10361)
  test(clickhouse-logger): to show that different endpoints will be chosen randomly (apache#8777)
  chore(deps): bump actions/setup-node from 3.8.1 to 4.0.0 (apache#10381)
  ci: fix the grpc test error (apache#10388)
  ci: trigger ci when doc-lint.yml changes (apache#10382)
  docs: fix usage of incorrect default admin api port (apache#10391)
  feat: Add authorization params to openid-connect plugin (apache#10058)
  feat: integrate authz-keycloak with secrets resource (apache#10353)
  fix(traffic-split): post_arg match fails because content-type contains charset (apache#10372)
  fix(consul): worker will not exit while reload or quit (apache#10342)
  chore: update rules for unresponded issues (apache#10354)
  docs: Update APISIX usecases in README (apache#10358)
  test: use http2 to test limit-req plugin (apache#10334)
  test: use http2 to test limit-conn plugin (apache#10332)
  chore: remove stream_proxy.only in config-default.yaml (apache#10337)
  docs: update underscore to hyphen in HTTP headers in `response-rewrite` plugin (apache#10347)
  fix: typos in comments (apache#10330)
  feat: support config stream_route upstream in service (apache#10298)
  fix: keep healthcheck target state when upstream changes (apache#10312)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants