You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Sn0rt Hi, I replied to your email yesterday, but I am not sure if you received it, so, I am pasting the email content now.
I basically agree with you idea. Now APISIX not use "validity_start" and "validity_start" fields no matter we set or read "ssl" resource. But APISIX Dashboard will set these fields when we add SSL resources, and it will display these fields on the web page, a user has raised an issue regarding this before. #10063
Maybe we should be compatible with this logic in APISIX Dashboard first, and remove these fields in APISIX.
What do you think?
I have not recive your reponse email yet. you can click the email list for confirm.
apache/apisix is the core project. to remove this field from apisix, we can merge it into it first.
APISIX-dashboard is a side project of APISIX and needs to be compatible with apisix instead of APISIX compatible with APISIX-dashboard. (I will create an issue under apisix-dashboard to track this requirement after this PR has been merged.)
The apisix-dashbaord compatibility guarantee is only up to 3.0.x. Currently, apisix has been released to 3.6.x.
I have not recive your reponse email yet. you can click the email list for confirm.
apache/apisix is the core project. to remove this field from apisix, we can merge it into it first.
APISIX-dashboard is a side project of APISIX and needs to be compatible with apisix instead of APISIX compatible with APISIX-dashboard. (I will create an issue under apisix-dashboard to track this requirement after this PR has been merged.)
The apisix-dashbaord compatibility guarantee is only up to 3.0.x. Currently, apisix has been released to 3.6.x.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10094
email: https://lists.apache.org/thread/8l4h8f6wcv482s0b7vt17do5z3g1y3o3
Checklist