fix: add name field in plugin_config schema for consistency#10315
Merged
Conversation
Signed-off-by: Ashish Tiwari <[email protected]>
Sn0rt
approved these changes
Oct 12, 2023
shreemaan-abhishek
approved these changes
Oct 12, 2023
juststillthinking
approved these changes
Oct 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes apache/apisix-ingress-controller#2003
All core resources like service, upstream , route, plugin have name field but plugin_config doesn't and after this PR where additional fields were prohibited, passing name in plugin_config gives an error. Ingress controller currently doesn't differentiate and adds name to plugin_config as well so currently there is this issue between apisix and ingress controller.
So this PR adds the name field to plugin_config to solve the compatibility issue and also for consistency
Checklist