feat: add jwe decrypt plugin#10252
Merged
Merged
Conversation
fishioon
changed the title
juststillthinking
marked this pull request as draft
September 25, 2023 03:42
Contributor
|
@fishioon click here when you are ready |
fishioon
marked this pull request as ready for review
September 25, 2023 03:44
Contributor
|
please make the ci pass |
juststillthinking
added
the
wait for update
Member
|
missing test cases and ci failed, pls fix them first |
fishioon
changed the title
fishioon
force-pushed
the
feat-jwe
branch
2 times, most recently
from
October 3, 2023 17:14
92ea674 to
fa89f03
Compare
Contributor
|
Good job! please make the ci pass, thanks! |
fishioon
force-pushed
the
feat-jwe
branch
7 times, most recently
from
October 9, 2023 05:38
49a424c to
e659cff
Compare
Contributor
|
@fishioon please make the ci pass |
fishioon
force-pushed
the
feat-jwe
branch
2 times, most recently
from
October 12, 2023 12:47
2e61384 to
b51f672
Compare
Contributor
Author
done |
moonming
requested review from
Revolyssup,
juststillthinking and
shreemaan-abhishek
October 17, 2023 07:01
shreemaan-abhishek
requested changes
Oct 18, 2023
shreemaan-abhishek
left a comment
shreemaan-abhishek
left a comment
Contributor
There was a problem hiding this comment.
code looks good to me. I haven't yet reviewed the doc tho.
Contributor
|
Thanks for you contribution! We will check this pr later |
| } | ||
| } | ||
| --- response_body | ||
| passed |
Contributor
There was a problem hiding this comment.
No real request test?
=== TEST 18: verify (in header)
--- request
GET /hello
--- more_headers
Authorization: Bearer eyJhbGciOiJkaXIiLCJraWQiOiJ1c2VyLWtleSIsImVuYyI6IkEyNTZHQ00ifQ..MTIzNDU2Nzg5MDEy.6JeRgm02rpOJdg.4nkSYJgwMKYgTeacatgmRw
--- response_body
hello world
Contributor
|
@fishioon please resolve the review comments |
Contributor
Author
@shreemaan-abhishek Help me! |
juststillthinking
approved these changes
Dec 1, 2023
juststillthinking
added
approved
and removed
wait for update
shreemaan-abhishek
approved these changes
Dec 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Like kong jwe-decrypt plugin.
Sometimes we need pass encrypt message with request header, like jwe
Fixes # (issue)
Checklist