change: creating core resources does not allow passing in create_time and update_time#10232
Merged
juststillthinking merged 3 commits intoOct 7, 2023
Merged
change: creating core resources does not allow passing in create_time and update_time#10232juststillthinking merged 3 commits into
create_time and update_time#10232juststillthinking merged 3 commits into
Conversation
Sn0rt
changed the title
create_time and update_time for resources in admin api
Sn0rt
marked this pull request as draft
September 20, 2023 01:44
Signed-off-by: Sn0rt <[email protected]>
Sn0rt
marked this pull request as ready for review
September 22, 2023 05:33
Sn0rt
changed the title
create_time and update_time for resources in admin apicreate_time and update_time
Comment on lines
+56
to
+58
| if conf.create_time then | ||
| return not_allow_create_time | ||
| end |
Contributor
There was a problem hiding this comment.
Is it possible to define a check list and sequentially check for properties that should not exist? like
local forbidden_properties = {create_time, update_time}
Contributor
Author
There was a problem hiding this comment.
great! I will fix it later
juststillthinking
added
wait for update
juststillthinking
approved these changes
Oct 7, 2023
juststillthinking
added
approved
and removed
wait for update
AlinsRan
approved these changes
Oct 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10094
email: https://lists.apache.org/thread/968kp7hd6zcg7ty2clomkbshmd53v71d
this PR depend on #10229
Checklist
@monkeyDluffy6017 @leslie-tsang pls help me to review