fix: graphql post request route matching exception#10198
Merged
Conversation
AlinsRan
marked this pull request as ready for review
September 14, 2023 01:18
AlinsRan
requested review from
juststillthinking,
kingluo,
leslie-tsang and
soulbird
September 14, 2023 02:15
juststillthinking
approved these changes
Sep 14, 2023
leslie-tsang
approved these changes
Sep 14, 2023
shreemaan-abhishek
pushed a commit
to shreemaan-abhishek/apisix
that referenced
this pull request
Jan 2, 2026
…ache#918) Co-authored-by: Xin Rong <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reuse of
match_optscauses the value of the next request to overwrite the value of the current request. GraphQL requests call thengx.req.read_bodyAPI, which is a non-blocking call. If the request body has not been fully read (for example, if the body size exceeds the nginx buffer), the coroutine will yield. If there are other requests during this time period,match_optswill be contaminated by other requests, resulting in matching the wrong route.Fixes: #10197
Checklist