docs(kafka-logger): inform bug with required_acks 0#10126
Merged
Conversation
Signed-off-by: Ashish Tiwari <[email protected]>
Signed-off-by: Ashish Tiwari <[email protected]>
Contributor
Author
|
@monkeyDluffy6017 The request still reaches kafka but the error occurs anyways. So should we remove |
Sn0rt
approved these changes
Sep 1, 2023
Sn0rt
approved these changes
Sep 1, 2023
pottekkat
reviewed
Sep 3, 2023
Co-authored-by: Navendu Pottekkat <[email protected]>
pottekkat
approved these changes
Sep 4, 2023
juststillthinking
approved these changes
Sep 5, 2023
juststillthinking
changed the title
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10073
lua-resty-kafka throws an error when required_acks value is 0 as mentioned here doujiang24/lua-resty-kafka#105 (comment)
This doc update reflects that and removes 0 from possible values.
Checklist