Skip to content

fix: remove Rust related scripts and doc update#10121

Merged
juststillthinking merged 2 commits into
apache:masterfrom
Revolyssup:revolyssup/rustremovaldoc
Sep 4, 2023
Merged

fix: remove Rust related scripts and doc update#10121
juststillthinking merged 2 commits into
apache:masterfrom
Revolyssup:revolyssup/rustremovaldoc

Conversation

@Revolyssup

@Revolyssup Revolyssup commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Description

This is a follow up PR to #9936 and removes mentions of RUST from docs as well as remove the scripts that install and check for rust.

Checklist

  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the APISIX mailing list first)

@Revolyssup Revolyssup self-assigned this Sep 1, 2023
shreemaan-abhishek
shreemaan-abhishek requested changes Sep 4, 2023
View reviewed changes

@shreemaan-abhishek shreemaan-abhishek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this as well:

apisix/t/chaos/utils/Dockerfile

Lines 39 to 43 in 35349ef

&& curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sudo sh -s -- -y \
&& source "$HOME/.cargo/env" \
&& export CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse \
# next line is for rust cdylib compile on musl
&& export RUSTFLAGS="-C target-feature=-crt-static" \

@Revolyssup

Revolyssup commented Sep 4, 2023

Copy link
Copy Markdown
Contributor Author

@shreemaan-abhishek done

@juststillthinking
juststillthinking merged commit 39a5d79 into apache:master Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shreemaan-abhishek shreemaan-abhishek shreemaan-abhishek approved these changes
@AlinsRan AlinsRan Awaiting requested review from AlinsRan
+2 more reviewers
@Sn0rt Sn0rt Sn0rt approved these changes
@juststillthinking juststillthinking juststillthinking approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@Revolyssup Revolyssup

Labels

None yet

Projects

⚡️ Apache APISIX Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Revolyssup @Sn0rt @juststillthinking @shreemaan-abhishek