feat: add schema validate admin API#10065
Conversation
moonming
left a comment
moonming
left a comment
There was a problem hiding this comment.
we need more test cases to cover invalid requests.
| "scheme": "https", | ||
| "type": "roundrobin", | ||
| "nodes": { | ||
| "nghttp2.org": 1 |
There was a problem hiding this comment.
| "nghttp2.org": 1 | |
| "httpbin.org": 1 |
There was a problem hiding this comment.
httpbin has been less stable in recent months, and now the community is using nghttp2 more.
Also, regarding schema checking, what matters here is not the actual value, but the type.
There was a problem hiding this comment.
yes.
FYI We can use httpbun.org also
This does not affect this PR
There was a problem hiding this comment.
how about https://mock.api7.ai/?
| "scheme": "https", | ||
| "type": "roundrobin", | ||
| "nodes": { | ||
| "nghttp2.org": 1 |
| "scheme": "https", | ||
| "type": "roundrobin", | ||
| "nodes": { | ||
| "nghttp2.org": 1 |
Co-authored-by: Abhishek Choudhary <[email protected]>
Co-authored-by: Abhishek Choudhary <[email protected]>
Co-authored-by: Abhishek Choudhary <[email protected]>
|
Just a question: why not doing the schema check automatically before users sending requests to any Admin API endpoints? The current approach, that is to ask users to send requests to a specific |
moonming
left a comment
moonming
left a comment
There was a problem hiding this comment.
we need more test cases not only in routes
The user's request already run the schema check. |
7 participants
Description
https://lists.apache.org/thread/6lsbhh4c9ytjmrkr0jt66j5s4vyh482k
Checklist