Current Behavior
When I use meta.filter in the plugin like this:
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '{
"plugins": {
"file-logger": {
"_meta": {
"filter": [
["upstream_status", "~=", 200]
]
},
"path": "logs/file.log"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"httpbin.org": 1
}
},
"uri": "/*"
}'
What I expect is that when the upstream_status is not equal to 200, then we will write a log into the file.
But now, the plugin will be executed even if the upstream_status is 200.
Reason:
Because when we do the plugin filter, we can't get the upstream_status (because we hadn't sent a request to upstream), so the value of ngx.var.upstream_status is nil, and the filter is always matched.
|
function _M.filter(ctx, conf, plugins, route_conf, phase) |
|
local user_plugin_conf = conf.value.plugins |
|
if user_plugin_conf == nil or |
|
core.table.nkeys(user_plugin_conf) == 0 then |
|
trace_plugins_info_for_debug(nil, nil) |
|
-- when 'plugins' is given, always return 'plugins' itself instead |
|
-- of another one |
|
return plugins or core.tablepool.fetch("plugins", 0, 0) |
|
end |
|
|
|
local custom_sort = false |
|
local route_plugin_conf = route_conf and route_conf.value.plugins |
|
plugins = plugins or core.tablepool.fetch("plugins", 32, 0) |
|
for _, plugin_obj in ipairs(local_plugins) do |
|
local name = plugin_obj.name |
|
local plugin_conf = user_plugin_conf[name] |
|
|
|
if type(plugin_conf) ~= "table" then |
|
goto continue |
|
end |
|
|
|
local matched = meta_filter(ctx, name, plugin_conf) |
|
local disable = check_disable(plugin_conf) |
|
if not disable and matched then |
|
if plugin_obj.run_policy == "prefer_route" and route_plugin_conf ~= nil then |
|
local plugin_conf_in_route = route_plugin_conf[name] |
|
local disable_in_route = check_disable(plugin_conf_in_route) |
|
if plugin_conf_in_route and not disable_in_route then |
|
goto continue |
|
end |
|
end |
|
|
|
if plugin_conf._meta and plugin_conf._meta.priority then |
|
custom_sort = true |
|
end |
|
core.table.insert(plugins, plugin_obj) |
|
core.table.insert(plugins, plugin_conf) |
|
end |
Expected Behavior
The meta.filter can work even if the plugin is run at the log phase.
Error Logs
No response
Steps to Reproduce
- Create route
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '{
"plugins": {
"file-logger": {
"_meta": {
"filter": [
["upstream_status", "~=", 200]
]
},
"path": "logs/file.log"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"httpbin.org": 1
}
},
"uri": "/*"
}'
- Send two requests
curl localhost:9080/status/200 -v
curl localhost:9080/status/400 -v
- We can see both requests are logged.
Environment
- APISIX version (run
apisix version): 2.15.0
- Operating system (run
uname -a):
- OpenResty / Nginx version (run
openresty -V or nginx -V):
- etcd version, if relevant (run
curl http://127.0.0.1:9090/v1/server_info):
- APISIX Dashboard version, if relevant:
- Plugin runner version, for issues related to plugin runners:
- LuaRocks version, for installation issues (run
luarocks --version):
Current Behavior
When I use meta.filter in the plugin like this:
What I expect is that when the upstream_status is not equal to 200, then we will write a log into the file.
But now, the plugin will be executed even if the upstream_status is 200.
Reason:
Because when we do the plugin filter, we can't get the upstream_status (because we hadn't sent a request to upstream), so the value of
ngx.var.upstream_statusis nil, and the filter is always matched.apisix/apisix/plugin.lua
Lines 421 to 458 in 47187fa
Expected Behavior
The meta.filter can work even if the plugin is run at the log phase.
Error Logs
No response
Steps to Reproduce
Environment
apisix version): 2.15.0uname -a):openresty -Vornginx -V):curl http://127.0.0.1:9090/v1/server_info):luarocks --version):