Skip to content

feat: append query string when using redirect with regex_uri #4229

Description

@Gary-Airwallex

Proposed changes

#4152 supports redirect with regex, but 1. it does not append the query string from original request to the Location header, and 2. it does not encode url. I suggest fxing these as in proxy-rewrite. If everyone agrees on this I'll create a PR for the change.

Concerns

Proposed changes do change the behavior of current implementation, and it will cause problems if

  1. someone expects the query string to be removed, or
  2. someone encodes url manually in plugin configuration, e.g. "regex_uri": ["/abc(.*)", "/ab%20c$1"],

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions