[AMORO-3851] Separate spark-3.3 and spark-3.5 modules #3848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:mixed-spark
turboFei
commented
Oct 31, 2025
| ExpressionEncoder encoder = (ExpressionEncoder) rowApplyMethod.invoke(null, structType); | ||
| return encoder.createSerializer().apply(row); | ||
| } catch (Throwable e) { | ||
| throw new RuntimeException(e); |
Member
Author
There was a problem hiding this comment.
this is a temporary workaround to support different Spark versions
turboFei
force-pushed
the
separate_spark3.3_3.5
branch
from
1fcd213 to
0f73351
Compare
turboFei
changed the title
turboFei
force-pushed
the
separate_spark3.3_3.5
branch
from
4838208 to
4e7226b
Compare
Contributor
I also tried compiling it with JDK 17 before. From what I remember, the issue might be caused by inconsistencies in how different JDK versions serialize certain Java classes. |
turboFei
force-pushed
the
separate_spark3.3_3.5
branch
from
c50284b to
0e2f726
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3848 +/- ##
============================================
- Coverage 29.00% 28.82% -0.18%
+ Complexity 3850 3838 -12
============================================
Files 631 625 -6
Lines 50770 50514 -256
Branches 6543 6455 -88
============================================
- Hits 14724 14561 -163
+ Misses 34989 34927 -62
+ Partials 1057 1026 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
turboFei
force-pushed
the
separate_spark3.3_3.5
branch
from
1ffccde to
0cc3a46
Compare
turboFei
changed the title
turboFei
changed the title
Member
Author
|
cc @xxubai @zhoujinsong |
xxubai
approved these changes
Oct 31, 2025
This was referenced Nov 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3851
Brief change log
Currently, it is not user friendly for developer to mix the spark-3.3 and spark-3.5 modules.
It is hard to build the modules for different spark modules together.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation