Skip to content

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented Jun 5, 2025

Why are the changes needed?

Close #3591.

Brief change log

  • Support Apache Paimon With OSS Object Store

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible
  • Add screenshots for manual tests if appropriate
  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

@czy006
Copy link
Contributor Author

czy006 commented Jun 5, 2025

image

Copy link
Contributor

@zhoujinsong zhoujinsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should control the default installation package size by making non-essential dependencies optional.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2025

Codecov Report

Attention: Patch coverage is 4.54545% with 21 lines in your changes missing coverage. Please review.

Project coverage is 28.30%. Comparing base (9ed1b83) to head (8a1abdf).
Report is 18 commits behind head on master.

Files with missing lines Patch % Lines
...server/dashboard/controller/CatalogController.java 0.00% 12 Missing ⚠️
...che/amoro/formats/paimon/PaimonCatalogFactory.java 10.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3593      +/-   ##
============================================
+ Coverage     21.76%   28.30%   +6.53%     
- Complexity     2391     3714    +1323     
============================================
  Files           436      617     +181     
  Lines         40498    49812    +9314     
  Branches       5743     6437     +694     
============================================
+ Hits           8816    14099    +5283     
- Misses        30935    34705    +3770     
- Partials        747     1008     +261     
Flag Coverage Δ
core 28.30% <4.54%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@czy006 czy006 requested review from klion26, xxubai and zhoujinsong June 12, 2025 08:44
@czy006 czy006 merged commit 756fbec into apache:master Jun 12, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Support Paimon With OSS Object Store

5 participants