Skip to content

Conversation

@czy006
Copy link
Contributor

@czy006 czy006 commented May 28, 2025

Why are the changes needed?

Close #3441.

Brief change log

  • bump to paimon 1.1.1
  • filter paimon format table in catalog
  • edit catalog exist method

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not documented)

@czy006 czy006 requested a review from huyuanfeng2018 May 29, 2025 03:18
@github-actions github-actions bot added the module:ams-server Ams server module label May 29, 2025
@czy006 czy006 force-pushed the issues/amoro-3441 branch from 480a427 to e2729fe Compare May 29, 2025 06:19
@github-actions github-actions bot added the module:mixed-spark Spark module for Mixed Format label May 29, 2025
@czy006
Copy link
Contributor Author

czy006 commented May 29, 2025

image

@czy006 czy006 force-pushed the issues/amoro-3441 branch from e2729fe to 9dce541 Compare May 29, 2025 07:47
@czy006 czy006 force-pushed the issues/amoro-3441 branch from 6337cd6 to e3481a2 Compare May 29, 2025 09:07
@czy006 czy006 force-pushed the issues/amoro-3441 branch from e3481a2 to 324d6b1 Compare May 29, 2025 09:26
@github-actions github-actions bot added the module:mixed-flink Flink moduel for Mixed Format label May 30, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 28.28%. Comparing base (e69710a) to head (1b39dfd).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
...he/amoro/formats/paimon/PaimonTableDescriptor.java 0.00% 8 Missing ⚠️
...org/apache/amoro/formats/paimon/PaimonCatalog.java 50.00% 4 Missing ⚠️
...apache/amoro/server/terminal/SparkContextUtil.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3581      +/-   ##
============================================
+ Coverage     21.76%   28.28%   +6.51%     
- Complexity     2391     3712    +1321     
============================================
  Files           436      617     +181     
  Lines         40498    49790    +9292     
  Branches       5743     6434     +691     
============================================
+ Hits           8816    14082    +5266     
- Misses        30935    34698    +3763     
- Partials        747     1010     +263     
Flag Coverage Δ
core 28.28% <27.77%> (?)
trino ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@huyuanfeng2018 huyuanfeng2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. I left a comment.

@czy006 czy006 requested a review from huyuanfeng2018 June 3, 2025 07:51
@huyuanfeng2018 huyuanfeng2018 merged commit f5247a2 into apache:master Jun 3, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module:ams-server Ams server module module:mixed-flink Flink moduel for Mixed Format module:mixed-spark Spark module for Mixed Format type:build

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: upgrade paimon version to 1.1.1

3 participants