[AMORO-3356] Include ResourceSerde interface and impl with Simple/Kryo/Java Serialize #3571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czy006
changed the title
…alize and KryoSerialize
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3571 +/- ##
============================================
+ Coverage 21.76% 28.27% +6.50%
- Complexity 2391 3703 +1312
============================================
Files 431 617 +186
Lines 40501 49779 +9278
Branches 5745 6432 +687
============================================
+ Hits 8816 14073 +5257
- Misses 30938 34698 +3760
- Partials 747 1008 +261
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
xxubai
reviewed
May 19, 2025
amoro-common/src/main/java/org/apache/amoro/serialization/KryoSerialize.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/serialization/SimpleSerialize.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/serialization/ResourceSerde.java
Outdated
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/serialization/ResourceSerde.java
Show resolved
Hide resolved
xxubai
reviewed
May 21, 2025
Contributor
xxubai
left a comment
xxubai
left a comment
There was a problem hiding this comment.
Have a good shape. Some small notes for you
amoro-common/src/main/java/org/apache/amoro/serialization/JavaSerializer.java
Show resolved
Hide resolved
amoro-common/src/main/java/org/apache/amoro/serialization/JavaSerializer.java
Outdated
Show resolved
Hide resolved
xxubai
approved these changes
May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include ResourceSerde interface and impl with SimpleSerialize/KryoSerialize/JavaSerialize
Their serialization/deserialization behavior was originally consistent with SequenceUtil
Before close #3361
Close #3356.
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation