[AMORO-3531] Support build project with JDK 8, 11 #3568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:docs
github-actions
bot
added
module:ams-server
github-actions
bot
removed
module:mixed-flink
xxubai
commented
May 21, 2025
| <iceberg.version>1.6.1</iceberg.version> | ||
| <paimon.version>0.9.0</paimon.version> | ||
| <hive.version>3.1.1</hive.version> | ||
| <hive.version>3.1.3</hive.version> |
| SerializationUtil.simpleDeserialize(task.getTaskInput()); | ||
| TableOptimizing.OptimizingInput input2 = | ||
| SerializationUtil.simpleDeserialize(task2.getTaskInput()); | ||
| Assertions.assertEquals(input2.toString(), input.toString()); |
Contributor
Author
There was a problem hiding this comment.
Make changes here because RewriteFilesInput is not equals after serialized via JDK9+. The MixedTable can not keep idential bytes
xxubai
changed the title
Contributor
Author
|
I find There are two threads insert the same table runtime record:
The error logs see: https://github.com/apache/amoro/actions/runs/15165798529/job/42643175684?pr=3568#step:5:27267 |
Contributor
|
how to specify jdk version when user compile? |
Contributor
Author
|
klion26
reviewed
May 26, 2025
Member
klion26
left a comment
klion26
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This can push we forward to support higher version of iceberg.
left some comments inline, please take a look when you're free.
…ved compatibility
Aireed
approved these changes
May 28, 2025
xxzhky
pushed a commit
to xxzhky/amoro
that referenced
this pull request
Sep 7, 2025
* Update CI configuration to support JDK 8, 11, and 17 * Update CI configuration to use actions/setup-java@v4 and actions/checkout@master * Update CI configuration to use JDK setup and Maven versions for improved compatibility * Revert CI configuration with comments * Update hive.version to 3.1.3 in pom.xml for compatibility * add extra java args * Replace './mvnw' with 'mvn' * revert * Refactor assertions to compare task ID only * Update pom.xml to enhance Java arguments for testing * remove jdk 17 * exclude slf4j-log4j12 confilct * Refactor CI configuration to simplify JDK setup and remove unnecessary parameters * Add Java version profile * remove * fix trino compile (cherry picked from commit b3f11aa)
xxubai
added a commit
to xxubai/amoro
that referenced
this pull request
Oct 14, 2025
* Update CI configuration to support JDK 8, 11, and 17 * Update CI configuration to use actions/setup-java@v4 and actions/checkout@master * Update CI configuration to use JDK setup and Maven versions for improved compatibility * Revert CI configuration with comments * Update hive.version to 3.1.3 in pom.xml for compatibility * add extra java args * Replace './mvnw' with 'mvn' * revert * Refactor assertions to compare task ID only * Update pom.xml to enhance Java arguments for testing * remove jdk 17 * exclude slf4j-log4j12 confilct * Refactor CI configuration to simplify JDK setup and remove unnecessary parameters * Add Java version profile * remove * fix trino compile (cherry picked from commit b3f11aa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Close #3531.
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation