[AMORO-3348] Extract the implementation of OptimizerManager #3437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baiyangtx
reviewed
Feb 17, 2025
Contributor
baiyangtx
left a comment
baiyangtx
left a comment
There was a problem hiding this comment.
You are welcomed to contribute to the project by contributing code. Generally speaking, there are no major issues with this PR. However, some implementation details can be optimized. I have left some comments. Please check them.
amoro-ams/src/main/java/org/apache/amoro/server/AmoroServiceContainer.java
Show resolved
Hide resolved
amoro-ams/src/main/java/org/apache/amoro/server/resource/DefaultOptimizerManager.java
Outdated
Show resolved
Hide resolved
mansonliwh
force-pushed
the
stateless-optimizer-manager
branch
from
03ecbb3 to
e127d7d
Compare
mansonliwh
changed the title
czy006
reviewed
Feb 18, 2025
amoro-ams/src/main/java/org/apache/amoro/server/DefaultOptimizingService.java
Show resolved
Hide resolved
baiyangtx
approved these changes
Feb 19, 2025
Contributor
baiyangtx
left a comment
baiyangtx
left a comment
There was a problem hiding this comment.
LGTM, thanks for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
close #3438 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation