[Improvement]: Controller dose not depend on TableService #3425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
module:ams-server
zhoujinsong
approved these changes
Feb 6, 2025
Contributor
zhoujinsong
left a comment
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for the contribution!
| * </script> | ||
| * </pre> | ||
| */ | ||
| public class InListExtendedLanguageDriver extends XMLLanguageDriver implements LanguageDriver { |
Contributor
There was a problem hiding this comment.
There are some code(OptimizingMapper, TableMetaMapper) still used old style, we may improve them in another PR.
17 tasks
zhoujinsong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
As a subtask of #3346, this PR will make RestController do not depend on TableService which is a statefull service
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation