I have pushed a build of this to dockerhub jhofman/incubator-airflow-ci:latest and am running the integration tests with the new image on a fork I am working on: https://travis-ci.org/johnhofman/incubator-airflow/builds/433982418.

The master branch still fails due to other dependency problems relating to the latest click release being incompatible with flask-appbuilder. That needs to be pinned to click==6.7 in the airflow setup.py.

@johnhofman I have raised a PR to pin click to 6.7 .However, I am not entirely sure if that would solve the issue.

@kaxil Cool! That will fix the click issue, but I think your build will still fail until this PR is also merged. Combined we should get a green build again.

I have added WIP because the tests on my fork failed. Because this fork includes other changes I won't know if it is the new ci image or my airflow changes. I will re-run the tests with the branch that @kaxil just patched to fix the click dependency issue.

https://travis-ci.org/johnhofman/incubator-airflow/builds/434014630

@johnhofman Looks like the tests are going through. And should be fine. Can you just address the comments that @ashb has in this PR?

The tests.operators.test_virtualenv_operator.TestPythonVirtualenvOperator tests are now failing for the py27_xxx_env_docker variants.

Anybody have any insight into what dependencies could have broken those tests?

@johnhofman I am looking into it now.

Still not entirely sure on why the tests related to PythonVirtualenvOperator is failing. It is somehow using protocol=3 for pickle.dump causing it to fail. Can you just add the comment that @ashb asked, we should merge this PR once that is done. Let's figure out the PythonVirtualenvOperator in a separate PR.

@kaxil The latest version of pip has change to Python 3.

+ pip --version
pip 18.0 from /usr/local/lib/python3.5/dist-packages/pip (python 3.5)
+ tox --version
3.4.0 imported from /usr/local/lib/python3.5/dist-packages/tox/__init__.py

where using the previous image it was Python 2

+ pip --version
pip 18.0 from /usr/local/lib/python2.7/dist-packages/pip (python 2.7)
+ tox --version
3.4.0 imported from /usr/local/lib/python2.7/dist-packages/tox/__init__.pyc

(Not familiar with this image, so this suggestion might not make sense) Could we fix this by explicitly mentioning pip2 or pip3?

I tried using pip2 or pip3 explicitly but it doesn't change the test results. I think the system python of the container has changed from Python2.7 to to Python3.5, probably from the updates to the xenial base image and/or the apt repositories.

This means all the python based tools like tox and virtualenv are now running in Python3.5, and the tests are assuming they run Python2.7.

I don't know which of these tools causes the problem, but I would guess virtualenv since it is the PythonVirtualenvOperator that is failing.

I have merged this one.

Good catch @johnhofman regarding python3 being used.
Let's figure out how we can resolve it now.

@seelmann @Fokko @dimberman Can one of you guys take a dig at resolving the above-mentioned issues. tests.operators.test_virtualenv_operator.TestPythonVirtualenvOperator are failing.

@kaxil I have a PR that fixes those tests. But now the KubernetesPodOperatorTests are timing out. I don't know if it is related to the changes I made or a different external dependency.

I think it has fixed it. Thanks @johnhofman