Python base image version is retrieved in the right place #9931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@kaxil @dimberman - this was the root cause for the wrongly generated requirements from Breeze. The temporary fix to solve 3.8.4 base image had some unforeseen consequences (in Breeze, not in the CI so only requirements generation was impacted). |
When quick-fixing Python 3.8.4 error apache#9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch.
potiuk
force-pushed
the
fix-problem-with-base-python-image-version
branch
from
e1be574 to
f669d97
Compare
Member
Author
|
I already have some :) |
potiuk
added a commit
that referenced
this pull request
Jul 22, 2020
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
kaxil
pushed a commit
that referenced
this pull request
Aug 11, 2020
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
When quick-fixing Python 3.8.4 error apache#9820 PYTHON_BASE_IMAGE_VERSION variable was added but it was initialized too early in Breeze and it took the default version of Python rather than the one chosen by --python switch. This caused the generated requirements (locally by Breeze only) to generate wrong set of requirements and images built locally for different python versions were based on default Python version, not the one chosen by --python switch. (cherry picked from commit 7b9e8e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When quick-fixing Python 3.8.4 error #9820 PYTHON_BASE_IMAGE_VERSION
variable was added but it was initialized too early in Breeze and
it took the default version of Python rather than the one chosen
by --python switch. This caused the generated requirements
(locally by Breeze only) to generate wrong set of requirements
and images built locally for different python versions were
based on default Python version, not the one chosen by --python
switch.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.