TimeSensor should consider the default_timezone config #9699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
approved these changes
Jul 17, 2020
Member
kaxil
left a comment
kaxil
left a comment
There was a problem hiding this comment.
Can you please rebase on the master branch to remove conflicts?
22quinn
force-pushed
the
time-sensor-timezone
branch
from
b754a8b to
b88cd95
Compare
Contributor
Author
Done. Thanks for the review. Do you mind also taking a look at #9697? It offers idempotence for |
Contributor
|
Cool, thank you! |
|
i see
…---Original---
From: "freget"<[email protected]>
Date: Sun, Jul 19, 2020 14:16 PM
To: "apache/airflow"<[email protected]>;
Cc: "Subscribed"<[email protected]>;
Subject: Re: [apache/airflow] TimeSensor should consider the default_timezone config (#9699)
Cool, thank you!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
I have two questions:
|
6 tasks
Contributor
Author
Good point. I was not aware of the existence of timezone-aware dags. Just created another PR to achieve this: #9882 |
kaxil
pushed a commit
that referenced
this pull request
Nov 20, 2020
(cherry picked from commit b34ba87)
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
(cherry picked from commit b34ba87)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9609
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.