Skip to content

Revert "Update some dependencies (#9684)" #9693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
potiuk merged 1 commit into from
Jul 6, 2020
Merged

Revert "Update some dependencies (#9684)" #9693

potiuk merged 1 commit into from
Jul 6, 2020

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 6, 2020

This reverts commit fd62b1c.

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk potiuk requested review from Fokko, ashb, feluelle, kaxil and turbaszek July 6, 2020 13:09
@potiuk
Copy link
Member Author

potiuk commented Jul 6, 2020

My #9690 was done one commit too late. I have not realized that but this setup update actually did break some tests. :). I think we should revert and reapplying this one after #9690. It would not be great to start the Summit with broken master.

@potiuk potiuk requested a review from mik-laj July 6, 2020 13:12
@potiuk
Copy link
Member Author

potiuk commented Jul 6, 2020 

    def _dot_lookup(thing, comp, import_path):
        try:
>           return getattr(thing, comp)
E           AttributeError: module 'azure.mgmt.containerinstance.operations' has no attribute 'ContainerOperations'

feluelle
feluelle approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@feluelle feluelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@potiuk potiuk merged commit f5e67eb into apache:master Jul 6, 2020
@potiuk potiuk deleted the revert-some-updates branch July 6, 2020 13:27
Fokko
Fokko reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaxil
kaxil reviewed Jul 6, 2020
View reviewed changes
Copy link
Member

@kaxil kaxil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@potiuk potiuk mentioned this pull request Jul 6, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fokko Fokko Fokko left review comments

@kaxil kaxil kaxil left review comments

@feluelle feluelle feluelle approved these changes

@ashb ashb Awaiting requested review from ashb

@turbaszek turbaszek Awaiting requested review from turbaszek

@mik-laj mik-laj Awaiting requested review from mik-laj

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@potiuk @Fokko @kaxil @feluelle