Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jul 5, 2020


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@potiuk
Copy link
Member Author

potiuk commented Jul 5, 2020

CC: @aneesh-joseph

@potiuk potiuk force-pushed the run-kubernetes-tests-for-older-airflow-version branch from 86a3bc4 to 0e0ddd7 Compare July 5, 2020 07:39
@dimberman
Copy link
Contributor

@potiuk would this run on every master PR? Seems like it might make sense on pushes to 1-10-test but not on master.

@potiuk
Copy link
Member Author

potiuk commented Jul 5, 2020

@potiuk would this run on every master PR? Seems like it might make sense on pushes to 1-10-test but not on master.

It also makes sense on master. I think we are going to release a chart from master that also works for latest released 1.10 version.. Ideally we should be able to release the helm chart from master (say with calver 2020.10.05 version that works nicely also for 1.10.11 image :).

@potiuk
Copy link
Member Author

potiuk commented Jul 5, 2020

We already rin similar tests for backport packages for example - we take the latest released airflow and we test if all the 'latest' backport packages can be installed with it.

@dimberman
Copy link
Contributor

Ahh ok I see where you're coming from. Since this isn't taking in any code changes and is instead just running against the most recent release... Though that raises the question: Are there any situations that would work for the NEXT release but not the current one? Though I guess that's a bridge we can cross if we get there.

@potiuk
Copy link
Member Author

potiuk commented Jul 6, 2020

Ahh ok I see where you're coming from. Since this isn't taking in any code changes and is instead just running against the most recent release... Though that raises the question: Are there any situations that would work for the NEXT release but not the current one? Though I guess that's a bridge we can cross if we get there.

I think it should never be the case. We have the rule (which I think we even written down in README) that whenever we introduce a breaking change in what we release, we do deprecation first and make it backwards compatible as a rule.

@potiuk potiuk force-pushed the run-kubernetes-tests-for-older-airflow-version branch from e38f5e5 to a64d21a Compare August 24, 2020 21:27
@potiuk potiuk mentioned this pull request Sep 4, 2020
3 tasks
@stale
Copy link

stale bot commented Oct 12, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Oct 12, 2020
@potiuk potiuk closed this Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools stale Stale PRs per the .github/workflows/stale.yml policy file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants