Extract TaskLogReader from views.py #9391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-laj
reviewed
Jun 18, 2020
airflow/www/views.py
Outdated
Member
There was a problem hiding this comment.
Does Javascript need to be updated?
Contributor
Author
There was a problem hiding this comment.
Everything is fine with the logging on the website
mik-laj
changed the title
mik-laj
changed the title
Member
|
@KevinYang21 Could you look at it? We need to extract logic to be able to reuse it in the API.@KevinYang21 |
mik-laj
reviewed
Jun 18, 2020
mik-laj
reviewed
Jun 18, 2020
mik-laj
reviewed
Jun 18, 2020
airflow/utils/log/log_reader.py
Outdated
mik-laj
reviewed
Jun 18, 2020
airflow/utils/log/log_reader.py
Outdated
mik-laj
reviewed
Jun 18, 2020
mik-laj
reviewed
Jun 18, 2020
mik-laj
reviewed
Jun 18, 2020
airflow/utils/log/log_reader.py
Outdated
Member
There was a problem hiding this comment.
Could you describe here how to use this function? I would be happy to add a code snippet to explain how to use metadata.
while 'end_of_log' not in metadata or not metadata['end_of_log']:
logs, metadata = self.read_log_chunks(ti, current_try_number, metadata)
for log in logs:
print(log)
Member
|
Please add a description to the PR |
Member
|
If we checkmark the box, let's actually follow the guidelines:
|
Contributor
Author
|
Hi @kaxil, please take a look, I have updated the description. Thanks for pointing this out. |
Member
|
@ephraimbuddy Can you do a rebase? |
turbaszek
reviewed
Jun 19, 2020
Co-authored-by: Kamil Breguła <[email protected]>
This reverts commit cbe163995f86fd69e298519b25fa07c7b857fce4.
This reverts commit edbf5c085f8d0d9de05a2775ae3683f1186eeb19.
turbaszek
approved these changes
Jun 19, 2020
mik-laj
approved these changes
Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic for reading task logs is implemented inside
views.py.This logic is also needed in API and it would be better if the logic is extracted from the view and tested separately. This will enable reuse of the logic in API
log_endpoint.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.