Skip to content

Conversation

@ephraimbuddy
Copy link
Contributor

@ephraimbuddy ephraimbuddy commented Jun 16, 2020


Closes: #8135
Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Jun 16, 2020
@ephraimbuddy ephraimbuddy marked this pull request as draft June 16, 2020 13:51
@ephraimbuddy ephraimbuddy marked this pull request as ready for review June 17, 2020 07:44
@ephraimbuddy
Copy link
Contributor Author

Depends on #9380

@ephraimbuddy
Copy link
Contributor Author

Depends on #9391

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should open in your browser to make it easier to view. Kubernetes API works in a similar way.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, how I can test that it opens in the browser but take a look at how I did it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can check the interaction with the browser by doing manual tests. :-D

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The token is encrypted metadata so that the user cannot manipulate it and affect its content.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'title': "Bad Signature. Please sign your token with URLSafeSerializer",
'title': "Bad Signature. Please use only the tokens provided by the API.",

Comment on lines 89 to 97
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This situation will never happen. This case was handled earlier. Errors should be returned as a response with an error code. Logs should not be used to send errors to the client.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you encountered any problems with this version of the library?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. The file was generated when I added accept_types as dependency. Now, I have removed it. I will regenerate requirements.

@mik-laj mik-laj merged commit 59035a0 into apache:master Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Endpoint - Logs

5 participants