Update (previously null) imap_default conn_type #9256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a test fixup to #9187, and updates the possibly existing imap_default connection, and adds that hook type to the various lists
kaxil
approved these changes
Jun 12, 2020
mik-laj
approved these changes
Jun 12, 2020
feluelle
approved these changes
Jun 12, 2020
Member
feluelle
left a comment
feluelle
left a comment
There was a problem hiding this comment.
Oh ya, I noticed this. This was on my todo list for a while. :/
Thanks Ash 👍
Member
Author
|
@feluelle with conn_type now being required column (and us not noticing this was a problem cos test weren't passing) it became waay more urgent :) |
Member
I knew of the unique conn_type change but didn't know we merged the related PR already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test fixup to #9187, and updates the possibly existing
imap_default connection, and adds that hook type to the various lists
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.