Skip to content

Conversation

@potiuk
Copy link
Member

@potiuk potiuk commented Jun 8, 2020

Please take a look at the last commit only. It is based on #9174


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

ashb added 2 commits June 7, 2020 22:03
It's fairly common to say whitelisting and blacklisting to describe
desirable and undesirable things in cyber security. However just because
it is common doesn't mean it's right.

However, there's an issue with the terminology. It only makes sense if
you equate white with 'good, permitted, safe' and black with 'bad,
dangerous, forbidden'. There are some obvious problems with this.

You may not see why this matters. If you're not adversely affected by
racial stereotyping yourself, then please count yourself lucky. For some
of your friends and colleagues (and potential future colleagues), this
really is a change worth making.

From now on, we will use 'allow list' and 'deny list' in place of
'whitelist' and 'blacklist' wherever possible. Which, in fact, is
clearer and less ambiguous. So as well as being more inclusive of all,
this is a net benefit to our understandability.

(Words mostly borrowed from
<https://www.ncsc.gov.uk/blog-post/terminology-its-not-black-and-white>)
@boring-cyborg boring-cyborg bot added area:dev-tools area:Scheduler including HA (high availability) scheduler provider:Apache labels Jun 8, 2020
@potiuk potiuk requested review from KevinYang21 and ashb June 8, 2020 04:27
@potiuk potiuk force-pushed the automate-language-matters-check branch from 25e54cd to bd9d1d8 Compare June 8, 2020 04:31
@potiuk
Copy link
Member Author

potiuk commented Jun 8, 2020

It's OK - just quarantined tests failed.

@potiuk
Copy link
Member Author

potiuk commented Jun 8, 2020

Closing as it was pulled in the #9174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dev-tools area:Scheduler including HA (high availability) scheduler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants