Skip to content

Conversation

@OmairK
Copy link
Contributor

@OmairK OmairK commented Jun 1, 2020

Closes #8131

Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@mik-laj mik-laj added the area:API Airflow's REST/HTTP API label Jun 1, 2020
@OmairK OmairK force-pushed the master branch 4 times, most recently from 21b8abe to d36994f Compare June 3, 2020 14:09
@mik-laj mik-laj changed the title [WIP] Scheama and CRUD endpoints Pool [WIP] Schema and CRUD endpoints Pool Jun 4, 2020
@OmairK OmairK force-pushed the master branch 2 times, most recently from ce9b79f to 36d3a3f Compare June 9, 2020 14:48
@OmairK OmairK requested a review from mik-laj June 10, 2020 06:56
Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OmairK OmairK changed the title [WIP] Schema and CRUD endpoints Pool Schema and CRUD endpoints Pool Jun 12, 2020
@OmairK OmairK changed the title Schema and CRUD endpoints Pool Schema and read endpoints Pool Jun 13, 2020
@mik-laj
Copy link
Member

mik-laj commented Jun 14, 2020

Github Action is sad. I think these are a flaky tests. However, to be sure, could you do a rebase? Over 3 red crosses are not good.

@OmairK OmairK force-pushed the master branch 3 times, most recently from b476fb8 to b758c23 Compare June 15, 2020 10:40
@OmairK
Copy link
Contributor Author

OmairK commented Jun 15, 2020

Github Action is sad. I think these are a flaky tests. However, to be sure, could you do a rebase? Over 3 red crosses are not good.

All the api_connexion tests are passing now.
Just one test is failing

tests/www/test_views.py

@OmairK OmairK requested a review from mik-laj June 15, 2020 12:07
@mik-laj
Copy link
Member

mik-laj commented Jun 15, 2020

@OmairK Can you do a rebase? We fixed test_views.py. #9307

@mik-laj mik-laj merged commit 3de6850 into apache:master Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API Endpoints - Read-only - Pools

3 participants