Add query count test for SchedulerJob #9088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
the
area:Scheduler
potiuk
approved these changes
Jun 1, 2020
mik-laj
reviewed
Jun 1, 2020
| ti.set_state(state=State.SCHEDULED) | ||
|
|
||
| mock_agent = mock.MagicMock() | ||
| mock_agent.harvest_simple_dags.return_value = [SimpleDag(d) for d in dagbag.dags.values()] |
Member
There was a problem hiding this comment.
The number of queries depends on whether this value is None or not.
airflow/airflow/jobs/scheduler_job.py
Line 1628 in 7c0e6ed
airflow/airflow/jobs/scheduler_job.py
Line 1650 in 7c0e6ed
dimberman
approved these changes
Jun 3, 2020
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.