Skip to content

Conversation

@kaxil
Copy link
Member

@kaxil kaxil commented Apr 28, 2020

closes #8599


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested a review from feluelle April 28, 2020 11:12
@kaxil kaxil requested review from feluelle and potiuk April 28, 2020 14:16
@kaxil
Copy link
Member Author

kaxil commented Apr 28, 2020

Added 54dc7f0 too as the tests were failing.

Context: email_validator made it an optional dependency by WTForms but is used by FAB and the added it to their dependency in 2.3.3 but if we use 2.3.2 we need to import email_validator ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airflow DAGs On/Off toggle button not working properly with RBAC=True mode

3 participants