Allow "falsey" default arguments in CLI Parser #8398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
reviewed
Apr 16, 2020
Member
|
One of the tests failed but might be just a flaky test: |
kaxil
approved these changes
Apr 16, 2020
Member
Author
|
Flakey test addressed (hopefully) in #8405 |
In apache#8219 we noticed that we couldn't set a `default=0` because of the `and v` check. The "add_argument" function in python avoid this by using **kwargs, but we want type checking so can't directly use the same there. This uses the same pattern that configparser does to allow falsey (0, False) and even `None` as valid values, distinct from not being passed.
ashb
force-pushed
the
allow-falsey-default-args
branch
from
d067acc to
d9a007c
Compare
Member
Author
|
Bored waiting for travis to run the K8s tests for a cli change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8219 we noticed that we couldn't set a
default=0because of theand vcheck. The "add_argument" function in python avoid this by using**kwargs, but we want type checking so can't directly use the same
there.
This uses the same pattern that configparser does to allow falsey (0,
False) and even
Noneas valid values, distinct from not being passed.Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.