Skip to content

Conversation

@boittega
Copy link
Contributor

@boittega boittega commented Apr 14, 2020

Issue #8195

Write guide for Apache Spark operators


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boittega boittega changed the title Create doc skeleton Guide for Apache Spark operators Apr 14, 2020
@kaxil
Copy link
Member

kaxil commented Apr 16, 2020

Static tests are failing, you might want to apply following diff:

diff --git a/docs/howto/connection/spark.rst b/docs/howto/connection/spark.rst
index bc68bfc3f..d52098cb3 100644
--- a/docs/howto/connection/spark.rst
+++ b/docs/howto/connection/spark.rst
@@ -38,6 +38,6 @@ Extra (optional)
 
     * ``queue`` - The name of the YARN queue to which the application is submitted.
     * ``deploy-mode`` - Whether to deploy your driver on the worker nodes (cluster) or locally as an external client (client).
-    * ``spark-home`` - If passed then build the ``spark-binary`` executable path using it (``spark-home``/bin/``spark-binary``); otherwise assume that ``spark-binary`` is present in the PATH of the executing user. 
+    * ``spark-home`` - If passed then build the ``spark-binary`` executable path using it (``spark-home``/bin/``spark-binary``); otherwise assume that ``spark-binary`` is present in the PATH of the executing user.
     * ``spark-binary`` - The command to use for Spark submit. Some distros may use ``spark2-submit``. Default ``spark-submit``.
     * ``namespace`` - Kubernetes namespace (``spark.kubernetes.namespace``) to divide cluster resources between multiple users (via resource quota).
diff --git a/docs/howto/operator/apache/spark.rst b/docs/howto/operator/apache/spark.rst
index be52ddde6..b256d9d09 100644
--- a/docs/howto/operator/apache/spark.rst
+++ b/docs/howto/operator/apache/spark.rst
@@ -38,4 +38,3 @@ SparkSqlOperator
 
 SparkSubmitOperator
 -------------------
-

@boittega boittega marked this pull request as ready for review April 22, 2020 22:42
@mik-laj mik-laj linked an issue Apr 22, 2020 that may be closed by this pull request
@zhongjiajie
Copy link
Member

I don't know why, but ci failed, maybe you should try to rebase on master?

2020-04-22T00:01:57.3558235Z tests/www/test_validators.py ...........                                 [ 92%]
2020-04-22T00:02:15.8983007Z tests/www/test_views.py ..............F
2020-04-22T00:02:15.8983749Z 
2020-04-22T00:02:15.8984188Z _______________________ TestAirflowBaseViews.test_clear ________________________
2020-04-22T00:02:15.8986811Z 
2020-04-22T00:02:15.8999414Z self = <tests.www.test_views.TestAirflowBaseViews testMethod=test_clear>

@boittega boittega force-pushed the 8195-create-doc-spark-operators branch from 2b5ba90 to daa1ae2 Compare April 23, 2020 09:00
@boittega boittega force-pushed the 8195-create-doc-spark-operators branch from 38d75a1 to cdb0340 Compare April 23, 2020 22:54
@boittega boittega requested a review from mik-laj May 3, 2020 11:14
@mik-laj
Copy link
Member

mik-laj commented May 3, 2020

One more thing. Can you add this tutorial to operators-and-hooks-ref.rst?
#8690
I am working to automatically check that the list has been updated, but for now we must remember that. Your PR was an inspiration for me to make this check, so your next contribution will be easier.

@boittega
Copy link
Contributor Author

boittega commented May 5, 2020

Ready to merge @mik-laj
Thank you.

@mik-laj mik-laj merged commit 487b5cc into apache:master May 5, 2020
@boittega boittega deleted the 8195-create-doc-spark-operators branch May 8, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide for Apache Spark operators

4 participants