-
Notifications
You must be signed in to change notification settings - Fork 16.3k
[AIRFLOW-6295] Create guide for BigQuery operators #8276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIRFLOW-6295] Create guide for BigQuery operators #8276
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
Codecov Report
@@ Coverage Diff @@
## master #8276 +/- ##
==========================================
+ Coverage 86.92% 87.64% +0.72%
==========================================
Files 920 937 +17
Lines 44387 45238 +851
==========================================
+ Hits 38582 39651 +1069
+ Misses 5805 5587 -218
Continue to review full report at Codecov.
|
|
Hi. Thank you for the guide, but could you put each operator in a separate section / subsection. This is important because it makes it much easier to find the information you need. Here ie example of guide with many section ("Managing an entries"), and subsection ("Creating an entries") |
|
@mik-laj I added subtitles for each operator except |
docs/howto/operator/gcp/bigquery.rst
Outdated
| .. _howto/operator:BigQueryGetDatasetTablesOperator: | ||
| .. _howto/operator:BigQueryPatchDatasetOperator: | ||
| .. _howto/operator:BigQueryUpdateDatasetOperator: | ||
| .. _howto/operator:BigQueryDeleteDatasetOperator: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move these labels closer to the corresponding sections, please? This is the last request because the rest looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, no worries. I moved each label above the section it belongs to.
|
I added the bigquery howto to |
mik-laj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but we have to wait for Travis. What are your plans for future contributions?
|
Yay! I work a lot with Airflow on GCP so I'll probably contribute more around that :) |
|
Airflow has a very active GCP user community. For sure you won't run out of tasks. 😸 I will try to regularly create new tickets with the "provider: GCP" label |
|
Awesome work, congrats on your first merged pull request! |
Fixes AIRFLOW-6295 / issue #8200.
I created a guide that describes how to use BigQuery service operators.
I added BigQueryCheckOperator, BigQueryValueCheckOperator, BigQueryIntervalCheckOperator to the example DAG.
Make sure to mark the boxes below before creating PR: [x]
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.