Skip to content

Conversation

@alexandraabbas
Copy link
Contributor

Fixes AIRFLOW-6295 / issue #8200.

I created a guide that describes how to use BigQuery service operators.

I added BigQueryCheckOperator, BigQueryValueCheckOperator, BigQueryIntervalCheckOperator to the example DAG.


Make sure to mark the boxes below before creating PR: [x]


In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@boring-cyborg boring-cyborg bot added area:docs provider:google Google (including GCP) related issues labels Apr 13, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 13, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

@mik-laj mik-laj self-requested a review April 13, 2020 20:16
@mik-laj mik-laj linked an issue Apr 13, 2020 that may be closed by this pull request
@codecov-io
Copy link

codecov-io commented Apr 14, 2020

Codecov Report

Merging #8276 into master will increase coverage by 0.72%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8276      +/-   ##
==========================================
+ Coverage   86.92%   87.64%   +0.72%     
==========================================
  Files         920      937      +17     
  Lines       44387    45238     +851     
==========================================
+ Hits        38582    39651    +1069     
+ Misses       5805     5587     -218     
Impacted Files Coverage Δ
...ders/google/cloud/example_dags/example_bigquery.py 100.00% <100.00%> (ø)
...flow/providers/apache/cassandra/hooks/cassandra.py 21.25% <0.00%> (-72.43%) ⬇️
...w/providers/apache/hive/operators/mysql_to_hive.py 35.84% <0.00%> (-64.16%) ⬇️
airflow/kubernetes/volume_mount.py 44.44% <0.00%> (-55.56%) ⬇️
airflow/providers/postgres/operators/postgres.py 47.82% <0.00%> (-52.18%) ⬇️
airflow/providers/redis/operators/redis_publish.py 50.00% <0.00%> (-50.00%) ⬇️
airflow/kubernetes/volume.py 52.94% <0.00%> (-47.06%) ⬇️
airflow/providers/mongo/sensors/mongo.py 53.33% <0.00%> (-46.67%) ⬇️
airflow/kubernetes/pod_launcher.py 47.18% <0.00%> (-45.08%) ⬇️
airflow/providers/mysql/operators/mysql.py 55.00% <0.00%> (-45.00%) ⬇️
... and 258 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b118916...ab1a5b9. Read the comment docs.

@mik-laj
Copy link
Member

mik-laj commented Apr 14, 2020

Hi. Thank you for the guide, but could you put each operator in a separate section / subsection. This is important because it makes it much easier to find the information you need.

Here ie example of guide with many section ("Managing an entries"), and subsection ("Creating an entries")

@alexandraabbas
Copy link
Contributor Author

@mik-laj I added subtitles for each operator except BigQueryExecuteQueryOperator as that is the only operator discussed in the section "Execute queries".

.. _howto/operator:BigQueryGetDatasetTablesOperator:
.. _howto/operator:BigQueryPatchDatasetOperator:
.. _howto/operator:BigQueryUpdateDatasetOperator:
.. _howto/operator:BigQueryDeleteDatasetOperator:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move these labels closer to the corresponding sections, please? This is the last request because the rest looks good.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, no worries. I moved each label above the section it belongs to.

@mik-laj mik-laj changed the title [Airflow-6295] Create guide for BigQuery operators [AIRFLOW-6295] Create guide for BigQuery operators Apr 14, 2020
@alexandraabbas alexandraabbas requested a review from mik-laj April 14, 2020 21:36
@mik-laj
Copy link
Member

mik-laj commented Apr 14, 2020

@alexandraabbas
Copy link
Contributor Author

I added the bigquery howto to operators-and-hooks-ref.rst

Copy link
Member

@mik-laj mik-laj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we have to wait for Travis. What are your plans for future contributions?

@alexandraabbas
Copy link
Contributor Author

Yay! I work a lot with Airflow on GCP so I'll probably contribute more around that :)

@mik-laj
Copy link
Member

mik-laj commented Apr 14, 2020

Airflow has a very active GCP user community. For sure you won't run out of tasks. 😸 I will try to regularly create new tickets with the "provider: GCP" label

@mik-laj mik-laj merged commit b198a1f into apache:master Apr 15, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Apr 15, 2020

Awesome work, congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

provider:google Google (including GCP) related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create guide for BigQuery operators

3 participants